Re: [U-Boot] [PATCH] net: warn about spaces in device names

Hi Mike,

On 6/9/2010 7:10 PM, Mike Frysinger wrote:

Some commands operate on eth device names (like 'mii'), but those cannot be passed on the command line as one argument. So detect devices like these and warn about them so someone will fix it.

Signed-off-by: Mike Frysingervapier@gentoo.org

net/eth.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/eth.c b/net/eth.c index b650a20..40e66e5 100644 --- a/net/eth.c +++ b/net/eth.c @@ -225,6 +225,9 @@ int eth_initialize(bd_t *bis) puts (" [PRIME]"); }

• 	if (strchr(dev->name, ' '))
  

• 		puts("\nWarning: eth device name has a space!\n");
  

• eth_getenv_enetaddr_by_index(eth_number, env_enetaddr);
  
  if (memcmp(env_enetaddr, "\0\0\0\0\0\0", 6)) {
  
  

Applied to net/next.

regards, Ben