Re: [U-Boot] [PATCH 4/5] powerpc: keymile: Add a check for the PIGGY debug board

Hi Heiko,

Heiko Schocher wrote:

Check the presence of the PIGGY on the keymile boards mgcoge, mgsuvd and kmeter1. If the PIGGY is not present, dont register this Ethernet device.

Signed-off-by: Heiko Schocher hs@denx.de

This looks like useful stuff to have, but I'd prefer that you put the check logic in board_eth_init() rather than adding to the individual device drivers. I know the 8260 SCC driver is the older style, which precludes the use of board_eth_init, but I'll convert it if you're able to test.

regards, Ben