Hi Quentin,
On 2024-04-02 16:02, Quentin Schulz wrote:
Hi Jonas,
On 3/31/24 22:28, Jonas Karlman wrote:
A lot of RK3399 boards use a u-boot,spl-boot-order of "same-as-spl", &sdhci and &sdmmc.
Move this to rk3399-u-boot.dtsi and make this default for boards currently missing a u-boot,spl-boot-order prop.
The &spi_flash reference has been dropped from spl-boot-order now that boot source id is cached and "same-as-spl" can be resolved into the SPI flash node.
This is not really the same thing.
This prevents from having U-Boot proper in SPI and TPL+SPL on eMMC/SD card. Is this a real usecase? I don't know, we do support it on Puma (though I know you haven't changed it in this commit). I guess we could still have the devices with SPI flashes have their own u-boot,spl-boot-order if they want.
Agree, I tweaked the commit message a little bit in v2.
I think before the SPI flash node had to be included in spl-boot-order to be able to load FIT from SPI flash, so the inclusion has probably mostly been an effect of that.
So, in short, I would at the very least document this new limitation in the commit log but have nothing against the change (my board not being impacted by it :) ).
Agree, I have been very restrictive and try not to change any behavior on gru based and puma targets :-
Regards, Jonas
Cheers, Quentin