Re: [U-Boot] [PATCH] Added watchdog support for davinchi_dm365evm

On Sunday 20 May 2012 12:50:40 Stijn Souffriau wrote:

--- a/board/davinci/dm365evm/dm365evm.c +++ b/board/davinci/dm365evm/dm365evm.c

+#ifdef CONFIG_HW_WATCHDOG +static struct davinci_timer * const wdttimer =

•    (struct davinci_timer *)CONFIG_SYS_WDTTIMERBASE;
  

+/* WDTCR bit definitions */ +#define WDEN (1 << 14) +#define WDFLAG (1 << 15) +#define WDKEY_SEQ0 (0xa5c6 << 16) +#define WDKEY_SEQ1 (0xda7e << 16)

if this is an on-chip hardware block, this stuff should be in an SoC-specific header

--- a/include/configs/davinci_dm365evm.h +++ b/include/configs/davinci_dm365evm.h

+// Hardware watchdog config

don't use // comment blocks. use /* ... */. -mike