Re: [PATCH] net: ti: am65-cpsw-nuss: don't touch DMA after stop

Hi Roger!

On Fri, 2024-05-10 at 12:11 +0300, Roger Quadros wrote:

...

Contrary to doc/develop/driver-model/ethernet.rst contract, eth_ops .free_pkt can be called after .stop, there are several error paths in TFTP, for instance:

Doesn't this mean we need to fix TFTP instead of patching the Ethernet driver? I'm sure the issue is present for all Ethernet drivers as none of them are checking if Ethernet is stopped. Just that most of them don't print any error message so it goes unnoticed.

Thanks for looking into this, your proposal makes sense to me! I'll rework!

Best regards,