Re: [U-Boot] [PATCH 23/25] pci: Tidy up comments in pci_bind_bus_devices()

On Tue, Nov 17, 2015 at 11:54 AM, Simon Glass sjg@chromium.org wrote:

The current comments are confusing. We don't actually bind a generic device when the device tree has no information. We try to scan available PCI drivers. Update the comments to reflect this.

Signed-off-by: Simon Glass sjg@chromium.org

drivers/pci/pci-uclass.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 9c54e6c..6374e96 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -672,9 +672,7 @@ int pci_bind_bus_devices(struct udevice *bus) /* Find this device in the device tree */ ret = pci_bus_find_devfn(bus, PCI_MASK_BUS(bdf), &dev);

•           /* Search for a driver */
  

•           /* If nothing in the device tree, bind a generic device */
  

•           /* If nothing in the device tree, bind a device */
            if (ret == -ENODEV) {
                    struct pci_device_id find_id;
                    ulong val;
  

--

Reviewed-by: Bin Meng bmeng.cn@gmail.com