On 11.11.2016 18:49, Soren Brinkmann wrote:
-----Original Message----- From: Michal Simek [mailto:monstr@monstr.eu] On Behalf Of Michal Simek Sent: November 11, 2016 05:42 To: u-boot@lists.denx.de Cc: Appana Durga Kedareswara Rao appanad@xilinx.com; Naga Sureshkumar Relli nagasure@xilinx.com; Bharat Kumar Gogada bharatku@xilinx.com; Hyun Kwon hyunk@xilinx.com; Albert Aribaud albert.u.boot@aribaud.net; Soren Brinkmann sorenb@xilinx.com; Filip Drazic filip.drazic@aggios.com Subject: [PATCH 26/27] ARM64: zynqmp: Add clocks for LPDDMA
From: Kedareswara rao Appana appana.durga.rao@xilinx.com
Zynqmp DMA driver expects two clocks (main clock and apb clock) For LPDDMA channels the two clocks are missing in the Dma node resulting probe failure.
xilinx-zynqmp-dma ffa80000.dma: main clock not found. xilinx-zynqmp-dma ffa80000.dma: Probing channel failed xilinx-zynqmp-dma: probe of ffa80000.dma failed with error -2
This patch fixes this issue.
Signed-off-by: Kedareswara rao Appana appanad@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
arch/arm/dts/zynqmp.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi index aeeccbf9e9d0..5b4fe0962e05 100644 --- a/arch/arm/dts/zynqmp.dtsi +++ b/arch/arm/dts/zynqmp.dtsi @@ -428,6 +428,7 @@ lpd_dma_chan1: dma@ffa80000 { status = "disabled"; compatible = "xlnx,zynqmp-dma-1.0";
clock-names = "clk_main", "clk_apb"; reg = <0x0 0xffa80000 0x0 0x1000>; interrupt-parent = <&gic>; interrupts = <0 77 4>;Am I missing something? Adding 'clock-names' without 'clocks' doesn't seem right.
Clocks were added in 1/27 http://lists.denx.de/pipermail/u-boot/2016-November/272338.html
The reason for this split is that this is cherry-pick of patches we did in Xilinx tree.
Thanks, Michal