14 Mar
2024
14 Mar
'24
12:29 p.m.
On Thu, Mar 14, 2024 at 02:41:29PM +0800, Jixiong Hu wrote:
Modified the ext4fs_write function to create a new file that inherits the inode->mode of existing file. To fix an issue where file permissions are changed after modifying the contents of an existing file.
I'm not an expert, but honestly the current behavior sound more correct than the proposed behavior. What's the issue specifically so we can understand it better? Also bug fixes need a Fixes tag.
The patch has a number of style issues and the existing_file_inode allocation is not always freed so those memory leaks would need to be fixed. For the style issues run ./scripts/checkpatch.pl on your patch.
regards, dan carpenter