On 04/25/2016 11:08 AM, Joe Hershberger wrote:
Hi Stephen,
On Wed, Apr 20, 2016 at 6:31 PM, Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
Currently, if multiple rtl8169 devices exist on the PCI bus, they all get the same name, which prevents the user from selecting which to use via the ethact environment variable. Port the auto-naming code from the e1000 driver to solve this.
... (issues with ethprime/ethact)
Equally, simply running e.g. "dhcp zImage" twice in a row doesn't seem to work; perhaps the subsequent attempts perform another lookup by name from ethact rather than just using the same device pointer from before?
I believe it does work in general. Are you saying that it doesn't work on your board without this patch?
Ah. The problem is that modifying ethprime after it's been used the first time has no effect. So, the following work:
pci enum setenv ethprime 'RTL8169#0' dhcp zImage
or:
pci enum setenv ethprime 'RTL8169#1' dhcp zImage
but this doesn't:
pci enum setenv ethprime 'RTL8169#0' dhcp zImage # Move Ethernet cable setenv ethprime 'RTL8169#1' dhcp zImage
I guess that makes sense given how ethprime is supposed to work, but was a bit confusing when I wasn't aware.