Dear Stefano,
in message 200706052139.16320.sbabic@denx.de you wrote:
I really dislike this mess of #ifdef's
I agree with you and I inserted this code against my will :)
;-)
However, I didn't want to have two different coding styles with different meaning inside the same file. In fact, some lines later the whole mess of #ifdef was already inserted for the ppc4xx architecture using CONFIG_CONS_INDEX to switch among the interfaces.
Please feel free to clean this up the same was as I suggested. I'm sure Stefan Roese will ACK such a change.
We should get rid of all this CONFIG_CONS_INDEX stuff.
I didn't want to change this part because this would break all ppc4xx boards that are not part of the U-Boot tree. So I preferred to add a lot of #ifdef using the same CONFIG defines as in ppc4xx instead of creating a new one.
I'm afraid I don't understand what you mean. Usually we don't care about boards that are not part of the U-Boot tree.
I will resend the patch with the modifications for the mpc8xx, without touching ppc4xx part. This would not break any custom board.
Please feel free to fix it for the existing 4xx boards as well. I'd really appreciate this, and I even volunteer to test it on a few of them.
Best regards,
Wolfgang Denk