Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Dear Anton Staaf,

In message CAF6FioXeFQP2a0VaZOVOTmxPvJxF4=kamS18=2=p6TFNefwUuA@mail.gmail.com you wrote:

...

what about adding a new func like: #define dma_buffer_alloca(size)

I generally avoid large allocations on the stack, they can confuse virtual stack management and blow out small embedded stacks. But neither of these are really a problem for most U-Boot targets. Are you thinking something like:

#define dma_buffer_alloca(size) alloca(size + get_dcache_line_size() -

1. & ~(get_dcache_line_size() - 1);

I don't think I will accept any alloca() based code into mainline.

Best regards,

Wolfgang Denk