Hi Steve,
On 15-07-07 06:27 AM, Lukasz Majewski wrote:
Hi Steve,
Signed-off-by: Steve Rae srae@broadcom.com
Changes in v2: None
drivers/usb/gadget/s3c_udc_otg.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/s3c_udc_otg.c b/drivers/usb/gadget/s3c_udc_otg.c index 7a2d1e7..2e3b4f7 100644 --- a/drivers/usb/gadget/s3c_udc_otg.c +++ b/drivers/usb/gadget/s3c_udc_otg.c @@ -414,7 +414,11 @@ static void reconfig_usbd(struct s3c_udc *dev) |0<<7 /* Ulpi DDR sel*/ |0<<6 /* 0: high speed utmi+, 1: full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ +#ifdef CONFIG_USB_GADGET_PHY_8_BIT
|0<<3 /* phy i/f 0:8bit, 1:16bit*/+#else |1<<3 /* phy i/f 0:8bit, 1:16bit*/ +#endif
Is your board using also host phy? As fair as I remember, the upper 8 bits are for host interface.
Hi Lukasz, Are you suggesting that we define this as a 16-bit interface, and then only use the upper 8-bits (to achieve the 8-bit interface)? Please clarify, Thanks Steve
As fair as I remember we use lower 8 bits for device PHY and upper for host.
Your board (with this Synopsys IP) should work with 16 bits as well.
|0x7<<0; /* HS/FS Timeout**/if (dev->pdata->usb_gusbcfg)
Despite my above question:
Acked-by: Lukasz Majewski l.majewski@samsung.com