Re: [U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset

In message 1212298724-15152-10-git-send-email-vapier@gentoo.org you wrote:

When available, use the on-chip syscontrol() rom function to perform a system reset rather than our own local method.

...

• asm("jump (%0);" : : "a" (bfin_reset));
  

• if (0 /*BOOTROM_CAPS_SYSCONTROL -- current silicon is broken*/)
  

• 	syscontrol(SYSCTRL_SOFTRESET, NULL, NULL);
  

• else
  

• 	asm("jump (%0);" : : "a" (bfin_reset));
  

}

Your comment suggests you change something, but actually you;re just adding dead code.

Rejected.

Best regards,

Wolfgang Denk