On Wednesday 26 March 2008, Haavard Skinnemoen wrote:
Using Markus's idea, why not use a cpu (platform) specific *and* a board specific init function, both with an empty weak alias in the common eth.c code:
cpu_eth_init(bis); board_eth_init(bis);
Why?
The whole point about this exercise is to get rid of board-specific knowledge in the common code. What is the purpose of cpu_eth_init()?
Because on PPC4xx for example, all boards are using exactly the same eth_init code (for the SoC interfaces). And I don't like adding this code to more than 80 boards.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================