Re: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to bitops.h

Dear Mike Frysinger,

In message 200908201344.37190.vapier@gentoo.org you wrote:

...

+#define __set_bit(nr, addr) generic_set_bit(nr, addr)

+#define __clear_bit(nr, addr) generic_clear_bit(nr, addr)

this is just silly to put into every arch header. why not do in the common code: #ifndef __set_bit # define __set_bit generice_set_bit #endif

Because it doesn't work?

The code usually looks like this: "static inline void __set_bit(...)..."

This defines a static inline function, but _not_ a preprocessor variable of that name.

Best regards,

Wolfgang Denk