On 12/14/2011 02:49 PM, Christian Riesch wrote:
Hi Tom, thanks for your reply.
On Wed, Dec 14, 2011 at 8:15 PM, Tom Rini <trini@ti.com mailto:trini@ti.com> wrote:
On 12/14/2011 12:09 PM, Christian Riesch wrote:
I applied the changes that I did in include/configs/da850evm.h before to da850_am18xxevm.h as well. I expected this to work on my board since the board I used to test the SPI flash SPL patchset for the da850evm was actually an AM1808 experimenter's kit.
Now my SPL reports:
SF: Unsupported manufacturer 20 failed.
Manufacturer 0x20 seems to be ST and the main difference between da850evm.h and da850_am18xxevm.h is the missing #define CONFIG_SPI_FLASH_STMICRO in da850_am18xxevm.h.
So my question is: Which boards are supported by da850_am18xxevm.h? I thought that I probably have an old revision of the board, but I couldn't find anything regarding SPI flash in LogicPD's PCNs.
So, the da850evm is for the OMAP-L138 and da850_am18xxevm is for the AM18xx EVM. However, the config split was done, I believe, but folks on the L138 side and might not have been tried fully on the am1808. So since you've got the AM1808 and can test it there, lets add the missing SPI_FLASH define too. I think my coworker that did a quick non-SPL check of the code the other week also noted SPI wasn't supported.
Ok, I can do that.
But then I wonder why a separate .h file for the AM18xx EVM was introduced. My AM18xx EVM works just fine with the da850evm.h configuration that's currently in mainline u-boot.
I did a diff between the two:
[snip explanation of how little is actually different]
I agree. It's on my list to unpack and get my am18xx EVM setup and see if perhaps we can't just use boards.cfg to build for L138 or AM1808.