11 Apr
2016
11 Apr
'16
7:45 a.m.
Hi Simon,
On Sat, Apr 09, 2016 at 12:33:37PM -0600, Simon Glass wrote:
Hi Peng,
On 21 March 2016 at 02:29, Peng Fan van.freenix@gmail.com wrote:
- Support compatible string "spi-gpio" which is used by Linux Linux use different bindings, so use UBOOT_COMPAT and LINUX_COMPAT to differentiate them.
There is only one user - instead of this, can you please drop the U-Boot binding and move the universal board over to use your new binding? There should be only one.
Ok. Will drop the U-Boot binding.
- Bug fix When doing xfer, should use device->parent, but not device When doing bit xfer, should use "!!(tmpdout & 0x80)", but not "(tmpdout & 0x80)"
- Introduce SPI_MASTER_NO_RX and SPI_MASTER_NO_TX to handle no rx or no tx case.
Perhaps put these two in separate patches?
Will try it.
Thanks, Peng.
- Tested on i.MX6 UltraLite board with 74LV595 spi-gpio chip.
Signed-off-by: Peng Fan van.freenix@gmail.com Cc: Simon Glass sjg@chromium.org Cc: Jagan Teki jteki@openedev.com Cc: Stefano Babic sbabic@denx.de
drivers/spi/soft_spi.c | 75 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 57 insertions(+), 18 deletions(-)
Regards, Simon