
2016-08-31 1:25 GMT+09:00 Stephen Warren swarren@wwwdotorg.org:
On 08/30/2016 12:56 AM, Masahiro Yamada wrote:
SPL_BUILD is not a CONFIG in Kconfig, so !SPL_BUILD is always true.
diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig
config TARGET_JETSON_TK1 bool "NVIDIA Tegra124 Jetson TK1 board"
select CPU_V7_HAS_NONSEC if !SPL_BUILD
select CPU_V7_HAS_VIRT if !SPL_BUILD
select CPU_V7_HAS_NONSEC
select CPU_V7_HAS_VIRT
Shouldn't this dependency be replaced with the correct dependency, rather than simply removed? I'm fairly sure those options should not be defined for SPL.
These lines were added by Ian. I was not sure if he meant "!SPL" here.
SPL is select'ed by TEGRA_ARMV7_COMMON, so it is not configurable.
config TEGRA_ARMV7_COMMON bool "Tegra 32-bit common options" select CPU_V7 select SPL select SUPPORT_SPL select TEGRA_COMMON select TEGRA_GPIO