Re: [U-Boot] [PATCH 3/4] Make printf and vprintf safe from buffer overruns

On Friday, September 23, 2011 13:38:51 Simon Glass wrote:

--- a/common/console.c +++ b/common/console.c @@ -212,7 +212,7 @@ int serial_printf(const char *fmt, ...) /* For this to work, printbuffer must be larger than * anything we ever want to print. */

• i = vsprintf(printbuffer, fmt, args);

• i = vscnprintf(printbuffer, CONFIG_SYS_PBSIZE, fmt, args);

i think sizeof(printbuffer) would be better. same goes for all the other changes here. -mike