Dear tmarri@apm.com,
In message 1283390223-28300-1-git-send-email-tmarri@apm.com you wrote:
From: Tirumala Marri tmarri@apm.com
Add support code for bluestone board wth APM82XXX processor based. This patch includes early board init, misc init, configure EBC, initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.
Signed-off-by: Tirumala R Marri tmarri@apm.com
...
--- a/MAINTAINERS +++ b/MAINTAINERS @@ -253,6 +253,9 @@ Feng Kan fkan@amcc.com
redwood PPC4xx
+Tirumala Marri tmarri@apm.com
- bluestone APM82XXX
Brad Kemp Brad.Kemp@seranoa.com
Please keep list sorted.
+int checkboard(void) +{
- char *s = getenv("serial#");
- printf("Board: Bluestone Evaluation Board");
Use puts() if no formatting is needed.
- if (s != NULL) {
puts(", serial# ");puts(s);- }
- putc('\n');
+/**************************************************************************
- TLB TABLE
- This table is used by the cpu boot code to setup the initial tlb
- entries. Rather than make broad assumptions in the cpu source tree,
- this table lets each board set things up however they like.
- Pointer to the table is returned in r1
- *************************************************************************/
Incorrect multiline comment style.
...
+#define SPD_EEPROM_ADDRESS {0x53, 0x51} /* SPD i2c spd addresses */
...
+#define CONFIG_SYS_I2C_EEPROM_ADDR (0xa8 >> 1)
...
+#define CONFIG_4xx_CONFIG_I2C_EEPROM_ADDR 0x52
For consistency with the other settings, please convert the "0xa8 >> 1" into 0x54.
Best regards,
Wolfgang Denk