Hi Wolfgang,
On Thursday 16 April 2009, Wolfgang Denk wrote:
Overwriting the function definition in "cpu/ppc4xx/speed.c" with a #define like here is pretty ugly.
Looking closer at this, I think the whole implementation of get_bus_freq() needs to be cleaned up. Why does get_bus_freq() need an agument? I don't see it used anywhere - not on 4xx nor on any other architecture.
Agreed. But this is a bigger task. Perhaps their is some volunteer somewhere doing such a cleanup.
But back to my little patch. What exactly do you want me to do now? With my patch the situation changes definitely to the better (from my point of view). But I can easily drop this patch from my patch series if you really don't want this change.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================