On 02/12/2016 09:51 AM, Jagan Teki wrote:
Hi York,
On 12 February 2016 at 22:25, york sun york.sun@nxp.com wrote:
On 02/12/2016 12:36 AM, Jagan Teki wrote:
Copy sf_dataflash.c from drivers/mtd/spi to spi-nor, more changes will see on future patches.
Cc: Bin Meng bmeng.cn@gmail.com Cc: Simon Glass sjg@chromium.org Cc: York Sun york.sun@nxp.com Cc: Haikun Wang haikun.wang@freescale.com Signed-off-by: Jagan Teki jteki@openedev.com
drivers/mtd/spi-nor/sf_dataflash.c | 701 +++++++++++++++++++++++++++++++++++++ 1 file changed, 701 insertions(+) create mode 100644 drivers/mtd/spi-nor/sf_dataflash.c
Jagan,
Does it make sense to squash the dataflash patches? The file sf_dataflash.c is copied, modified, renamed. Do we need to keep the detail of changes?
I thought of doing all at once, but this shows the history how spi_flash uclass driver becomes mtd uclass driver that's my intention, did you find anything wrong with this approach?
No, I didn't find anything wrong. I was thinking the new file doesn't get compiled until the Makefile is updated.
York