On 03/24/2017 07:25 PM, Yuiko.Oshino@microchip.com wrote:
From: Yuiko Oshino yuiko.oshino@microchip.com
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Friday, March 10, 2017 2:19 PM To: Yuiko Oshino - C18177; u-boot@lists.denx.de Subject: Re: [PATCH v2] Add support for Microchip LAN78xx
On 03/10/2017 07:38 PM, Yuiko.Oshino@microchip.com wrote:
From: Yuiko Oshino yuiko.oshino@microchip.com
Add support for Microchip LAN7800 and 7850, USB to 10/100/1000 Ethernet Controllers
Signed-off-by: Yuiko Oshino yuiko.oshino@microchip.com Cc: Marek Vasut marex@denx.de
Changes for v2:
- lan78xx.c header comment cleanup
[...]
Why does a lot of this stuff look like the SMSC95xx driver ? Do we even need a separate driver or can the SMSC95xx driver be updated to support the LAN78xx ?
Marek, Thank you so much for your review. The LAN78xx's register addresses and bit definitions are not compatible to our old part LAN95xx (==SMSC95xx). The new devices LAN78xx and LAN75xx device have similarities. I plan to support these two devices in this driver. I will take care of all your comments and will submit a new PATCH with a file name change to lan7x.c.
Is the rename really mandatory ?
Then again, I looked into Linux and that one has two separate drivers . So I wonder if it's really a good idea. Maybe we can share some common code and have the rest separate ?