Dear Wolfgang,
I'm doing some work on i386 at the moment and: a) It seems PCI is already broken - see [PATCH 0/2] Update i386 code (sc520_cdp) (http://lists.denx.de/pipermail/u-boot/2008-September/040099.html) b) The board I'm porting to doesn't use PCI c) I don't have a sc520 board with PCI to test on
My vote would be to commit and fix up i386 later when someone needs PCI
Harsh, but true
Regards,
Graeme
On Thu, Sep 18, 2008 at 1:36 PM, Nobuhiro Iwamatsu iwamatsu@nigauri.org wrote:
Hi, Wolfgang .
I did a simple check.
Only powerpc and i386 and sh seem to use PCI. If powerpc does not have a problem, would you commit it?
Best regards, Nobuhiro
2008/9/7 Wolfgang Denk wd@denx.de:
Dear Nobuhiro Iwamatsu,
In message 20080829103949.022a6e45.iwamatsu@nigauri.org you wrote:
A source code of pci is written mainly on powerpc. Macro uses a pci source code of powerpc because other architecture (ex. SuperH) doesn't work.
I made asm-ppc/pci.h and moved macro of pci. Other archtecture need to make the following macro in asm-xxx/pci.h #define pci_phys_to_mem(dev, addr) (addr) #define pci_mem_to_phys(dev, addr) (addr) #define pci_phys_to_io(dev, addr) (addr) #define pci_io_to_phys(dev, addr) (addr)
Or have to make a function for pci address conversion. However, I want comment because I do not know the other architecture.
To me the patch looks OK, but I'm not an expert for al the affected architectures.
Hello everybody, please comment!!
Otherwise I will just apply the patch and then not listen to your complaints if it breaks anything.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de History tends to exaggerate. -- Col. Green, "The Savage Curtain", stardate 5906.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Nobuhiro Iwamatsu _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot