Dear Peter,
in message 000001c7f488$c4d288d0$9a4d010a@Emea.Arm.com you wrote:
The following issues need to be addressed: include/led.h => seems specific to the at91rm9200dk board only, please move to board directory. Also, the calls to these functions should be handled without #ifdef's in common code. Either use existing functions hooks, or weak references.
Moved to asm-arm as coloured_led.h
I still would rather have this integrated into the existing status_led driver.
- I want to play with the coloured leds on other ARM boards sometime.
Please feel free to do so.
drivers/at45.c => has coding style issues - indentation of long, wrapped around lines is broken.
- ran Lindent on it
Actually the new version is even worse. It has many lines which are not indented by multiple of 8 chars.
Please clean this up.
Best regards,
Wolfgang Denk