Re: [U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting

Dear Rob Herring,

In message 1328138854-28612-1-git-send-email-robherring2@gmail.com you wrote:

--- a/doc/README.enetaddr +++ b/doc/README.enetaddr @@ -32,7 +32,9 @@ Correct flow of setting up the MAC address (summarized):

1. Read from hardware in initialize() function
2. Read from environment in net/eth.c after initialize()

-3. Give priority to the value in the environment if a conflict +3. Write value to environment if setup in struct eth_device->enetaddr by driver

• initialize() function. Give priority to the value in the environment if a
• conflict.

Sorry, but this description is not correct. You say here that the environment variable should always be written, but this is not the case. Only if it does not exist it shall be set. If it exists, it shall only be read, and in case of inconsistencies a warning shall be printed.

Best regards,

Wolfgang Denk