On Tuesday, 7 January 2014 12:59 AM, Tom Rini trini@ti.com wrote:
On Sun, Jan 05, 2014 at 08:02:07PM +0530, Sanjeev Premi wrote:
Beagleboard XM doesn't have a NAND chip. Let the configuration reflect so.
Signed-off-by: Sanjeev Premi spremi@ymail.com Cc: Tom Rini trini@ti.com
True, but why? And please note that:
Because there is no NAND on certain BeagleXM, but saveenv would result in:
OMAP3 beagleboard.org # saveenv Saving Environment to NAND... Erasing NAND... Attempt to erase non block-aligned data OMAP3 beagleboard.org #
Can be a problem when someone is working on mixed revisions of beagle boards esp. on a remote setup.
+#ifdef CONFIG_BEAGLE_XM +#define CONFIG_ENV_IS_IN_MMC +#define CONFIG_SYS_MMC_ENV_DEV 0 +#else +#define CONFIG_ENV_IS_IN_NAND +#endif /* CONFIG_BEAGLE_XM */
Means that we'll be using part of the SD card for the stored environment so a 'saveenv' will start breaking peoples SD cards if they didn't re-partition them.
Understood. But today everyone is using and can continue to use omap3_beagle_config. But someone explicitly using BeagleXM and expect saveenv to work on BeagleXM, manual change won't be required with each U-Boot release.
~sanjeev
-- Tom