Re: [U-Boot] [PATCH v1 10/16] drivers: Add SPMI bus uclass

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Hi Simon ,

On 11.01.2016 17:57, Simon Glass wrote: [...]

...

@@ -0,0 +1,10 @@ +menu "SPMI support"

+config DM_SPMI

Can we just use SPMI, or is that is use? We want to remove all the DM_ options when everything is converted to driver model. So if you are adding a new class you should be able to avoid the DM_ prefix.

Sure, I thought it's mandatory :)

[..]

...

+#include <common.h> +#include <dm.h> +#include <dm/root.h> +#include <errno.h> +#include <spmi/spmi.h> +#include <linux/ctype.h>

http://www.denx.de/wiki/U-Boot/CodingStyle

common.h dm.h errno.h dm/... spmi/... linux/...

Oops, this slipped - my bad

Regards, Mateusz