Re: [U-Boot] [PATCH 2/8] kmp204x: handle dip-switch for factory settings

On 04/30/2014 06:01 AM, Valentin Longchamp wrote:

From: Stefan Bigler stefan.bigler@keymile.com

<snip>

diff --git a/board/keymile/kmp204x/qrio.c b/board/keymile/kmp204x/qrio.c index 11949f4..c4f8dfd 100644 --- a/board/keymile/kmp204x/qrio.c +++ b/board/keymile/kmp204x/qrio.c @@ -158,3 +158,16 @@ void qrio_set_leds(void) ctrlh |= (CTRLH_WRL_BOOT | CTRLH_WRL_UNITRUN); out_8(qrio_base + CTRLH_OFF, ctrlh); }

+#define CTRLL_OFF 0x03 +#define CTRLL_WRB_BUFENA 0x20

+void qrio_enable_app_buffer(void) +{

• u8 ctrll;
• void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE;

You need a blank line here.

• /* enable application buffer */
• ctrll = in_8(qrio_base + CTRLL_OFF);
• ctrll |= (CTRLL_WRB_BUFENA);
• out_8(qrio_base + CTRLL_OFF, ctrll);

+}