Re: [PATCH v2 1/1] drivers: usb: host: Add BRCM xHCI driver

On 4/7/20 8:29 AM, Rayagonda Kokatanur wrote: [...]

+static int xhci_brcm_probe(struct udevice *dev) +{

• struct xhci_hccr *hcd;
• struct xhci_hcor *hcor;
• struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
• uintptr_t hc_base;
• int len, ret = 0;

Reverse xmas tree please.

[...]

+static int xhci_brcm_deregister(struct udevice *dev) +{

• struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
• uintptr_t hc_base;
• hc_base = (uintptr_t)dev_read_addr(dev);

You should cache the hc_base in driver private data instead of always reading it out of the DT.

The rest looks good, thanks.