Re: [PATCH] spl: provide weak empty stub for reset_cpu()

On Thu, Aug 17, 2023 at 05:35:37PM +0300, Oleksandr Suvorov wrote:

This stub needs to link SPL properly.

Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io

common/spl/spl.c | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/common/spl/spl.c b/common/spl/spl.c index 0062f3f45d9..781858891b9 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -1026,3 +1026,11 @@ ulong bootcount_load(void) return 0; } #endif

+/**

• • Weak default function for board-specific reset. Provide empty stub only.
• */

+__weak void reset_cpu(void) +{

• /* Nothing to do! */

+}

NAK, there are already architectures and SoCs that have a weak reset_cpu. If you're working on one without reset_cpu, it needs to be implemented one way or another, not like this.