On Wed, 2018-06-13 at 10:24 +0200, Mario Six wrote:
Hi Alexey,
On Mon, Jun 4, 2018 at 6:05 PM, Alexey Brodkin Alexey.Brodkin@synopsys.com wrote:
Hi Mario,
On Wed, 2018-05-23 at 14:09 +0200, Mario Six wrote:
Especially for commands, it is useful to be able to turn a hexadecimal string into its binary representation.
Hence, import the hex_to_bin, bin2hex, and hex2bin functions from the Linux kernel.
Signed-off-by: Mario Six mario.six@gdsys.cc
v1 -> v2: New in v2
Something is missing?
Note there was a similar discussion some time ago here: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_pa... XO7breS55ytWkhpk5R81I&m=mnw00As1T_NpnFNncTURuK4YkIAYD-Dj-VTNkRqquVY&s=HcgjkTO1GdtGqH9sYIjizH30AC3m_Xfa1F6n_Cy_qZY&e=, might worth checking.
If of any interest you may pick up my earlier patch and do fix-ups mentioned by Tom:
- Move hexdump.h away from common.h
- Update existing users of print_hex_dump() in U-Boot such that they don't use debug level (i.e. drop the first argument)
Or I may do the same re-spin sometime soon.
Thanks for your feedback! I saw that you posted a re-spin of your patch; Thank you, that's very helpful.
FWIW Tom just pulled that in, see http://git.denx.de/?p=u-boot.git;a=commit;h=f8c987f8f127f867d96ca74bcd1fcb11...
Still read-on for a couple of comments for your patch.
[snip]
/*
- min()/max()/clamp() macros that also do
- strict type-checking.. See the
diff --git a/lib/Makefile b/lib/Makefile index d531ea54b31..0f6d744579f 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -29,6 +29,7 @@ obj-$(CONFIG_FIT) += fdtdec_common.o obj-$(CONFIG_TEST_FDTDEC) += fdtdec_test.o obj-$(CONFIG_GZIP_COMPRESSED) += gzip.o obj-$(CONFIG_GENERATE_SMBIOS_TABLE) += smbios.o +obj-y += hexdump.o
U-Boot might be used on targets with limited memory so having ability to include hexdump or not might be beneficial here. Especially in production builds why would you need hexdump?
Yes, it's probably better to have it deactivatable, true. But as for why production builds need hexdump: It's not so much the hexdump function, but the bin2hex function, which can be used in a number of U-Boot commands that read hexadecimal data. We use one such command to initialize a TPM on one of our boards, for example.
I spoke a bit too soon as I forgot what I did before :) We don't disable building of entire hexdump.o instead in hexdump.c we just put some code in #ifdefs that way you may move bin2hex() outside #ifdef.
-Alexey