16 Jan
2008
16 Jan
'08
11:27 p.m.
On 22:26 Wed 16 Jan , Wolfgang Denk wrote:
In message 1200517000.31842.70.camel@localhost you wrote:
#define MAX_LEN 80 static char tftp_filename[MAX_LEN];
strncpy(tftp_filename, str, MAX_LEN); tftp_filename[MAX_LEN-1] = 0;
May be truncated, but never overruns.
Acked-by: wd@denx.de :-)
Except that the length should be 128 to match the boot file name length that BOOTP / DHCP can pass as per RFC.
Personnaly, I'll prefer 1K length because if you use as I use a lost of time a full path when downloading uImage or other so a path with a length over than 512 arrive often.
And with nfs it's the same
Best Regards, J.