On 12/18/2013 08:07 PM, Jagan Teki wrote:
On Wed, Dec 18, 2013 at 9:07 PM, Marek Vasut marex@denx.de wrote:
On Wednesday, December 18, 2013 at 04:30:08 PM, Jagannadha Sutradharudu Teki wrote:
Added support for Zynq Nand controller driver.
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com CC: Marek Vasut marex@denx.de Cc: Scott Wood scottwood@freescale.com
V2: Fixed issues pointed by Scott
arch/arm/include/asm/arch-zynq/hardware.h | 2 + drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/zynq_nand.c | 1198 +++++++++++++++++++++++++++++ 3 files changed, 1201 insertions(+) create mode 100644 drivers/mtd/nand/zynq_nand.c
[...]
+#define zynq_nand_smc_base ((struct zynq_nand_smc_regs __iomem *)\
ZYNQ_SMC_BASEADDR)Why don't you make this a static const * variable ?
For accessing base from all func - may be I will through structure pointer and access.
Jagan as I told you you shouldn't add this patch and also that qspi one to this series. qspi and nand should go as separate patches out of this series. Then there is exact responsibility for it.
Thanks, Michal