On 01/06/2015 09:40 AM, Sjoerd Simons wrote:
On Mon, 2015-01-05 at 13:18 -0700, Stephen Warren wrote:
On 01/05/2015 10:13 AM, Sjoerd Simons wrote:
New command to determine the filesystem type of a given partition. Optionally stores the filesystem type in a environment variable.
diff --git a/common/cmd_fs.c b/common/cmd_fs.c
+U_BOOT_CMD(
- fstype, 4, 1, do_fstype_wrapper,
- "Look up a filesystem type",
- "<interface> <dev>:<part>\n"
Should this line ...
- "- print filesystem type\n"
- "fstype <interface> <dev>:<part> <varname>\n"
... be consistent with this one - namely either both or neither include "fstype" at the start?
Nope, the cmd_usage implementation does (summarized):
printf("Usage:\n%s ", cmdtp->name); puts(cmdtp->help); putc('\n');
So the "fstype" at the start of the first line gets added by that code, hence the declaration needs to be inconsistent to have a consistent output for the user :)
Ah right. In that case, Reviewed-by: Stephen Warren swarren@nvidia.com