Re: [U-Boot] [PATCH] ahci: Fix compiling warnings under 64bit platforms

6 Jul 2015


      Please see the reply in line.
...
-----Original Message-----
From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass
Sent: Friday, July 03, 2015 10:41 PM
To: Tang Yuantian-B29983
Cc: Tom Rini; Hans de Goede; U-Boot Mailing List; Xie Shaohui-B21989
Subject: Re: [PATCH] ahci: Fix compiling warnings under 64bit platforms
...
@@ -135,9 +135,9 @@ struct ahci_sg {
 };
struct ahci_ioports {

  u32     cmd_addr;


  u32     scr_addr;


  u32     port_mmio;




  void __iomem    *cmd_addr;


  void __iomem    *scr_addr;


  void __iomem    *port_mmio;



You could change those to ulong instead of pointers. Also there is
map_sysmem() which converts a physical address (which can be defined
as 32-bit even on a 64-bit machine if so-decided) into a pointer.
I prefer to use "void __iomem *" here for port_mmio because it is aligned to "ahci_probe_ent->mmio_base" which is also void __iomem *.
Cmd_addr and scr_addr are aligned to port_mmio also.
The rest of your comments will be addressed in next version.
Regards,
Yuantian
...
...
    struct ahci_cmd_hdr     *cmd_slot;
    struct ahci_sg          *cmd_tbl_sg;
    u32     cmd_tbl;

--
2.1.0.27.g96db324
Regards,
Simon

    

Yuantian Tang