Hi Ken,
On 23 March 2017 at 03:29, make@marvell.com wrote:
From: Ken Ma make@marvell.com
*** BLURB HERE ***
You might want to try patman which can generate patches, cover letter and change logs for you.
- Move base, max_lun and max_id such scsi generic data from platdata to uclass plat data;
- Make scsi compatible for legacy SCSI devices and new SAS controller
- Introduce scsi bus DT node, scsi work as bus and scsi disks, scsi scanner and sata are its children scsi device; this is similar to the case that spi bus manages spi flashes; In such case, scsi bus probe should probe its children devices automatically;
- SAS controller can also be a scsi node as current.
- Example with mvebu armada 3700 scsi bus node
This looks good as far as it goes. As a general comment I'd like to see SCSI operations (as we have e.g. for MMC - struct dm_mmc_ops) so that we can move it fully to DM.
Ken Ma (7): scsi: move base, max_lun and max_id to uclass plat data scsi: add children devices binding scsi: call children devices' probe functions automatically scsi: dt-bindings: add scsi device tree bindings scsi: mvebu: add scsi driver scsi: a3700: enable mvebu scsi driver scsi: dts: a3700: add scsi node
arch/arm/dts/armada-3720-db.dts | 4 ++ arch/arm/dts/armada-37xx.dtsi | 16 +++++-- common/scsi.c | 2 +- configs/mvebu_db-88f3720_defconfig | 2 + .../scsi/marvell,mvebu-scsi.txt | 29 ++++++++++++ doc/device-tree-bindings/scsi/scsi-bus.txt | 22 +++++++++ drivers/block/Kconfig | 10 ++++ drivers/block/Makefile | 1 + drivers/block/ahci.c | 2 +- drivers/block/mvebu_scsi.c | 31 +++++++++++++ drivers/block/scsi-uclass.c | 54 +++++++++++++++++++++- 11 files changed, 165 insertions(+), 8 deletions(-) create mode 100644 doc/device-tree-bindings/scsi/marvell,mvebu-scsi.txt create mode 100644 doc/device-tree-bindings/scsi/scsi-bus.txt create mode 100644 drivers/block/mvebu_scsi.c
-- 1.9.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Regards, Simon