On Fri, 2009-07-17 at 16:32 +0200, Heiko Schocher wrote:
Hello André,
André Schwarz wrote:
Heiko,
this patch is no longer valid since I already posted v2.
Ah, ok.
But your comments are correct ...
Will wait for WD's comments and send v3.
OK, one more minor comment ...
On Fri, 2009-07-17 at 16:15 +0200, Heiko Schocher wrote:
Hello André,
André Schwarz wrote:
This patch fixes DDR-II settings and adds I2C support.
Signed-off-by: André Schwarz andre.schwarz@matrix-vision.de
include/configs/MVBLM7.h | 48 ++++++++++++++++++++------------------------- 1 files changed, 21 insertions(+), 27 deletions(-)
diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h index ac8cb57..6e347e8 100644 --- a/include/configs/MVBLM7.h +++ b/include/configs/MVBLM7.h @@ -47,12 +47,14 @@ #define CONFIG_MPC8XXX_SPI #define CONFIG_HARD_SPI #define MVBLM7_MMC_CS 0x04000000 +#define CONFIG_MISC_INIT_R
So misc_init_r () gets called, but I didn;t find this in your patch? May I miss something ...
It's included in the other "common code" patch.
Hmm... but this will break git-bisect compatibility, and if we have such a tool for searching bugs, we should make patches which are "git bisect compatible" ... so please look, that patches compile clean ...
yes - that's what WD has been complaining ... it's now a single patch.
bye Heiko
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschiaeftsf�hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich