-----Original Message----- From: Albert ARIBAUD [mailto:albert.aribaud@free.fr] Sent: Wednesday, October 06, 2010 11:22 AM To: Chris Moore Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] orion5x: optimize window size computation
Le 05/10/2010 23:40, Chris Moore a écrit :
Hi Prafulla,
Le 05/10/2010 07:57, Prafulla Wadaskar a écrit :
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Albert Aribaud Sent: Tuesday, October 05, 2010 3:52 AM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] orion5x: optimize window size
computation
Signed-off-by: Chris Mooremoore@free.fr
This is a simple optimization of the orion5x window size computation. This code was contributed by Chris Moore so I put his Signed-off-by rather than mine.
This is wrong, you should be singed-off since you are posting and Chris can be contributor Or let him post the patch.
Ack
I asked Albert to post the patch as I am mainly a U-Boot
lurker and I
have no U-Boot git tree. If there is a problem I don't mind if he signs off either with or without me.
Or how about a double Signed-off-by?
BTW: double Signed-off-by is not a bad idea, lot other patches follows the same. I wouldn't mind to ack such patches. May be Wolfgang can better comment on this.
BTW: How much this saves on size?
More than 53% of the code size! That's 28 bytes instead of 60. :)
Great!! Thanks Chris, we will update the same for Kirkwood too.
Regards.. Prafulla . .