Hi,
-----Original Message----- From: Tom Rini trini@konsulko.com Sent: Wednesday, 11 August, 2021 4:57 AM To: Marek Vasut marex@denx.de Cc: u-boot@lists.denx.de; Simon Goldschmidt simon.k.r.goldschmidt@gmail.com; Chee, Tien Fong tien.fong.chee@intel.com Subject: Re: [PATCH 1/1] arm: socfpga: Migrate CONFIG_HPS namespace to HPS
On Tue, Aug 10, 2021 at 10:53:02PM +0200, Marek Vasut wrote:
On 8/10/21 10:47 PM, Tom Rini wrote:
On Tue, Aug 10, 2021 at 10:11:08PM +0200, Marek Vasut wrote:
On 8/10/21 10:05 PM, Tom Rini wrote:
None of the CONFIG_HPS namespace options are changed via the board config.h file, nor does it make sense to move them to Kconfig. Rename these options to the HPS namespace instead.
Cc: Marek Vasut marex@denx.de Cc: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com Cc: Tien Fong Chee tien.fong.chee@intel.com Signed-off-by: Tom Rini trini@konsulko.com
Note, this patch is complete as the changes to the regex qts-filter.sh are such a long line that git send-email fails. This patch was generated by: $ git grep -l CONFIG_HPS_ | xargs sed -i -e 's/CONFIG_HPS_/HPS_/g' and I will re-run that before applying.
The problem is, it is the altera tools which generate all those CONFIG_* symbols which are processed by the qts-filter.sh and placed into those qts/ board directories, so this patch breaks all that. You'd have to fix the qts-filter to scrub the CONFIG_ prefixes first.
Or rather, ugh, are there out of tree tools we need to deal with here? Perhaps someone with the tools could pick up and v2 something tested if so as it'll probably be a bit tricky getting it all right.
See doc/README.socfpga . The out of tree tools generate board/bitstream specific input header files which you plug into the qts-filter.sh script , those files contain the CONFIG_* macros and those files get converted by the qts-filter.sh script into the output header files in board/*/qts/*.h . The output header files are what is used by U-
Boot then.
So doc/README.socfpga needs to be updated to rST as well, when someone that can run the tools and test the scripts work as expected and don't use the CONFIG_HPS namespace. Thanks for explaining a bit more.
Thanks for cleaning these up, the scripts are also required to get changed and testing. I will work with internal team to get these done, include converting doc/README.socfpga into rST as well.
TF
-- Tom