On Sun, 2014-07-20 at 01:22 +0200, Wolfgang Denk wrote:
Dear Ian Campbell,
In message 1405712321-12334-1-git-send-email-ijc@hellion.org.uk you wrote:
In 73545f75b66d "ahci: wait longer for link" I increased the timeout to 40ms based on the observed behaviour of a WD disk on a Cubietruck. Since then Karsten Merker and myself have both observed timeouts with HGST disks (Karsten on Cubietruck, me on Cubieboard2). Increasing the timeout to ~175ms fixes this, so go to 200ms for a bit of headroom.
Is there not some specification anywhere which defines a maximum time that is allowed for the link to come up?
I did have a look way back when I originally wrote the patch and if it exists I can't find it.
#define WAIT_MS_SPINUP 20000 #define WAIT_MS_DATAIO 5000 #define WAIT_MS_FLUSH 5000 -#define WAIT_MS_LINKUP 40 +#define WAIT_MS_LINKUP 200
BTW: All these names are just horrible from a name space point of view :-(
I suppose their saving grace is at least they are only in a .c file.
Ian.