A newly created property is currently not freed if a name could not be allocated. This patch fixes the resulting memory leak in the error patch.
Reported-by: Coverity (CID: 184085) Fixes: e369e58df79c ("core: Add functions to set properties in live-tree") Signed-off-by: Mario Six mario.six@gdsys.cc --- drivers/core/ofnode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index 1e354803b0..5182eb7149 100644 --- a/drivers/core/ofnode.c +++ b/drivers/core/ofnode.c @@ -825,8 +825,10 @@ int ofnode_write_prop(ofnode node, const char *propname, int len, return -ENOMEM;
new->name = strdup(propname); - if (!new->name) + if (!new->name) { + free(new); return -ENOMEM; + }
new->value = (void *)value; new->length = len; -- 2.16.4