6 May
2013
6 May
'13
9:15 p.m.
Dear Dirk,
In message 3628fded6de7e6b4286d3444a7e5e3ec@gdsys.cc you wrote:
total: 3 errors, 0 warnings, 509 lines checked
OK, thanks, that makes sense. Which version of checkpatch are you using? Latest u-boot master checkpatch/patman does not show these (at least not for me).
It does for me, interestingly ONLY if the current directory is NOT in the U-Boot tree.
Apparently both the COMPLEX_MACRO and MULTISTATEMENT_MACRO_USE_DO_WHILE option should better be enabled, or we will miss such issues.
Added Joe to Cc: - Joe, what do you think? I'd rather remove the silencing for these from .checkpatch.conf ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
An optimist believes we live in the best world possible; a pessimist
fears this is true.