Re: [Patchv4 2/3] arm: dts: Add mmc alias to avoid warning

Hi Neil,

On Wed, 22 Jan 2020 at 17:44, Neil Armstrong narmstrong@baylibre.com wrote:

Hi,

On 22/01/2020 13:06, Anand Moon wrote:

...

Add missing mmc alias to dts nodes to avoid below debug warning.

mmc_bind: alias ret=-2, devnum=-1 mmc_bind: alias ret=-2, devnum=-1

Signed-off-by: Anand Moon linux.amoon@gmail.com

arch/arm/dts/meson-axg-s400.dts | 2 ++ arch/arm/dts/meson-g12a-sei510.dts | 3 +++ arch/arm/dts/meson-g12a-u200.dts | 3 +++ arch/arm/dts/meson-g12b-odroid-n2.dts | 3 +++ arch/arm/dts/meson-gxbb-odroidc2.dts | 3 +++ arch/arm/dts/meson-gxbb-p20x.dtsi | 3 +++ arch/arm/dts/meson-gxl-s805x-libretech-ac.dts | 3 +++ arch/arm/dts/meson-gxl-s905x-p212.dtsi | 3 +++ arch/arm/dts/meson-gxm-khadas-vim2.dts | 3 +++ arch/arm/dts/meson-sm1-sei610.dts | 3 +++ 10 files changed, 29 insertions(+)

diff --git a/arch/arm/dts/meson-axg-s400.dts b/arch/arm/dts/meson-axg-s400.dts index 18778ada7b..b0192a9720 100644 --- a/arch/arm/dts/meson-axg-s400.dts +++ b/arch/arm/dts/meson-axg-s400.dts @@ -58,6 +58,8 @@ aliases { serial0 = &uart_AO; serial1 = &uart_A;

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  linein: audio-codec@0 {
  

diff --git a/arch/arm/dts/meson-g12a-sei510.dts b/arch/arm/dts/meson-g12a-sei510.dts index c7a8736885..0e6378a320 100644 --- a/arch/arm/dts/meson-g12a-sei510.dts +++ b/arch/arm/dts/meson-g12a-sei510.dts @@ -31,6 +31,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  mono_dac: audio-codec-0 {
  

diff --git a/arch/arm/dts/meson-g12a-u200.dts b/arch/arm/dts/meson-g12a-u200.dts index 8551fbd4a4..88b4d365f8 100644 --- a/arch/arm/dts/meson-g12a-u200.dts +++ b/arch/arm/dts/meson-g12a-u200.dts @@ -16,6 +16,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-g12b-odroid-n2.dts b/arch/arm/dts/meson-g12b-odroid-n2.dts index 42f1540575..888429b1cc 100644 --- a/arch/arm/dts/meson-g12b-odroid-n2.dts +++ b/arch/arm/dts/meson-g12b-odroid-n2.dts @@ -18,6 +18,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts index 54954b314a..1436002013 100644 --- a/arch/arm/dts/meson-gxbb-odroidc2.dts +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts @@ -17,6 +17,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-gxbb-p20x.dtsi b/arch/arm/dts/meson-gxbb-p20x.dtsi index 0be0f2a5d2..d55f5e1abb 100644 --- a/arch/arm/dts/meson-gxbb-p20x.dtsi +++ b/arch/arm/dts/meson-gxbb-p20x.dtsi @@ -11,6 +11,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-gxl-s805x-libretech-ac.dts b/arch/arm/dts/meson-gxl-s805x-libretech-ac.dts index 82b1c48511..6422e11e5e 100644 --- a/arch/arm/dts/meson-gxl-s805x-libretech-ac.dts +++ b/arch/arm/dts/meson-gxl-s805x-libretech-ac.dts @@ -20,6 +20,9 @@ serial0 = &uart_AO; ethernet0 = &ethmac; spi0 = &spifc;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-gxl-s905x-p212.dtsi b/arch/arm/dts/meson-gxl-s905x-p212.dtsi index a1b31013ab..d712e9fa1d 100644 --- a/arch/arm/dts/meson-gxl-s905x-p212.dtsi +++ b/arch/arm/dts/meson-gxl-s905x-p212.dtsi @@ -17,6 +17,9 @@ serial0 = &uart_AO; serial1 = &uart_A; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-gxm-khadas-vim2.dts b/arch/arm/dts/meson-gxm-khadas-vim2.dts index 782e9edac8..723061f0e2 100644 --- a/arch/arm/dts/meson-gxm-khadas-vim2.dts +++ b/arch/arm/dts/meson-gxm-khadas-vim2.dts @@ -20,6 +20,9 @@ serial0 = &uart_AO; serial1 = &uart_A; serial2 = &uart_AO_B;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  

diff --git a/arch/arm/dts/meson-sm1-sei610.dts b/arch/arm/dts/meson-sm1-sei610.dts index 3435aaa4e8..3aafc20ccd 100644 --- a/arch/arm/dts/meson-sm1-sei610.dts +++ b/arch/arm/dts/meson-sm1-sei610.dts @@ -17,6 +17,9 @@ aliases { serial0 = &uart_AO; ethernet0 = &ethmac;

•         mmc0 = &sd_emmc_a;
  

•         mmc1 = &sd_emmc_b;
  

•         mmc2 = &sd_emmc_c;
  };
  
  chosen {
  
  

Since it's not a linux binding but u-boot specific, please move these to the -u-boot.dtsi instead

Neil

Thanks for your review.

Ok I will move all the aliase to common meson-gx-u-boot.dtsi file..

-Anand