Re: [PATCH v4 03/11] rtc: fall back to ->{read,write} if ->{read,write}8 are not provided

Hello Rasmus,

Am 06.07.2020 um 22:01 schrieb Rasmus Villemoes:

Similar to how the dm_rtc_{read,write} functions fall back to using the {read,write}8 methods, do the opposite in the rtc_{read,write}8 functions.

This way, each driver only needs to provide either ->read8 or ->read to make both rtc_read8() and dm_rtc_read() work - without this, a driver that provides ->read() would most likely just duplicate the logic here for implementing a ->read8() method in term of its ->read() method. The same remarks of course apply to the write case.

Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Heiko Schocher hs@denx.de Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk

---

drivers/rtc/rtc-uclass.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-)

Applied to u-boot-i2c.git master

Thanks!

bye, Heiko