On Sun, Aug 12, 2018 at 03:06:03PM +0800, Akee Huang wrote:
Fix coding style according to checkpatch.pl
Signed-off-by: Akee Huang akeeoao@gmail.com
cmd/led.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/cmd/led.c b/cmd/led.c index fc07ca95a3..b339c98dfb 100644 --- a/cmd/led.c +++ b/cmd/led.c @@ -133,10 +133,10 @@ int do_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) #define BLINK "" #endif
-U_BOOT_CMD(
- led, 4, 1, do_led,
- "manage LEDs",
- "<led_label> on|off|toggle" BLINK "\tChange LED state\n"
- "led [<led_label>\tGet LED state\n"
- "led list\t\tshow a list of LEDs"
+U_BOOT_CMD(led,
4, 1, do_led,"manage LEDs","<led_label> on|off|toggle" BLINK "\tChange LED state\n""led [<led_label>\tGet LED state\n""led list\t\tshow a list of LEDs");
This is indeed a style violation. However, a quick 'git grep' shows that we really don't have consistency here. And to the extent that we do it's following the style that checkpatch.pl doesn't like and we're doing in cmd/led.c. So, in the absence of a Coccinelle (or simlar) script and proposal to get everything consistent, I don't think this patch by itself is a good idea to apply, sorry.