On 07/14/2011 02:30 PM, David Jander wrote:
You have to protect the code related to TO2 with CONFIG_MX51. As I can see, the macro is called for MX.53, too, and the test produces wrong results.
Wow, you are right! So this code was actually broken in more ways than I initially thought :-)
Yes, with one shot you hit more bugs...
Ok, will fix it (again). Btw, may I congratulate you for your good work in improving u-boot code quality? It is starting to get to a level only known from LKML ;-)
Congratulations go to all participants and reviewers of this ML, who are helping to improve the quality of the code ;-)
Clearly the code was not reviewed as well when this was initially submitted.
That is right - some issues was not seen and not fixed in time.
Best regards, Stefano Babic