Hi Tony,
On 3/28/24 08:41, Michael Walle wrote:
Hi,
On Thu Mar 28, 2024 at 3:18 AM CET, Tony Dinh wrote:
Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the DEFAULT_DEVICE_TREE for Kirkwood boards. And so we can directly build DTBs from dts/upstream/src/arm/marvell, and including *-u-boot.dtsi files from arch/arm/dts/ directory.
Background:
Hi Stefan, Hi Michael,
I did a survey and we currently have 28 Kirkwood boards. Using some commands and filters, here are the finding.
git grep -li arch_kirkwood configs | xargs grep DEVICE_TREE | cut -d '"' -f2 | xargs -n1 sh -c 'diff -qs arch/arm/dts/$1.dts dts/upstream/src/arm/marvell/$1.dts' sh | grep differ
diff: dts/upstream/src/arm/marvell/kirkwood-atl-sbx81lifkw.dts: No such file or directory diff: dts/upstream/src/arm/marvell/kirkwood-atl-sbx81lifxcat.dts: No such file or directory
...
Are you sure you want to have all this text in the commit log?
This is also my concern. Even though I love descriptive commit messages, this seems to be a bit too much IMHO. Not sure if and how to get these findings of yours archived otherwise.
You seem to have forgotten my tag: Tested-by: Michael Walle michael@walle.cc # on lschv2
Tony, many thanks to work on this consolidation. Very impressive results. I can't test anything of this though, but my plan would be to pull this in the upcoming merge window, if nobody complains.
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan