Re: [U-Boot] [PATCH] bmp: Respect "splashpos" if it is defined

Hello Otavio,

Sorry for delay.

On Thu, 6 Jun 2013 14:57:23 -0300 Otavio Salvador otavio@ossystems.com.br wrote: ...

+#ifdef CONFIG_SPLASH_SCREEN_ALIGN

• s = getenv("splashpos");
• if (s != NULL) {

• if (s[0] == 'm')
  

• 	x = BMP_ALIGN_CENTER;
  

• else
  

• 	x = simple_strtol(s, NULL, 0);
  

• s = strchr(s + 1, ',');
  

• if (s != NULL) {
  

• 	if (s[1] == 'm')
  

• 		y = BMP_ALIGN_CENTER;
  

• 	else
  

• 		y = simple_strtol(s + 1, NULL, 0);
  

• }
  

• }

+#endif /* CONFIG_SPLASH_SCREEN_ALIGN */

This code is already there in two other drivers, we should better add a common function for "splashpos" checking and use it here. I'll submit a patch shortly.

Thanks,

Anatolij