Hi Ilias,
On Thu, 12 Dec 2024 at 08:48, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
On Thu, 12 Dec 2024 at 17:46, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
On Thu, 12 Dec 2024 at 15:44, Simon Glass sjg@chromium.org wrote:
Hi Ilias,
On Wed, 11 Dec 2024 at 23:22, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
On Wed, 11 Dec 2024 at 17:53, Simon Glass sjg@chromium.org wrote:
Hi Ilias,
On Wed, 11 Dec 2024 at 07:51, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
On Wed, 11 Dec 2024 at 15:54, Simon Glass sjg@chromium.org wrote: > > Update efi_allocate_pool_ext() to log the pointer returned from this > call, which can be helpful when debugging.
Can you explain how logging the success is helping? I think its pretty pointless, why not log a failure?
It shows the memory address that was allocated.
Sure, but that's not what I asked.
On failure, the address is undefined, so logging it just adds confusion. It will likely be a random number.
I mean just report a failure to update. What use can the allocated address be of?
Can you please rewrite the patch so I can understand what you are getting at?
Thanks /Ilias
> > Signed-off-by: Simon Glass sjg@chromium.org > --- > > (no changes since v3) > > Changes in v3: > - Show the returned address rather than the pointer > > Changes in v2: > - Use EFI_PRINT() instead of log_debug() > > lib/efi_loader/efi_boottime.c | 4 ++++ > 1 file changed, 4 insertions(+) >
Applied to sjg/master, thanks!